feat: support to process tag #1806
Open
+3,596
−927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abingcbc
changed the title
henryzhx8
requested changes
Oct 21, 2024
Comment on lines
+288
to
+289
| bool IsKeyExist(const Json::Value& config, const std::string& key); | ||
|
|
| const std::string HOST_IP_DEFAULT_KEY = "host.ip"; | ||
| #endif | ||
|
|
||
| } // namespace logtail |
| bool enableContainerDiscovery); | ||
| StringView GetFileTagKeyName(TagKey key) const; | ||
|
|
||
|
|
|
|
||
| #include "file_server/FileTagOptions.h" | ||
|
|
||
| #include "common/ParamExtractor.h" |
There was a problem hiding this comment.
cpp文件都直接用using namespace std吧，代码里的std可以删了
| const Json::Value* tagConfig = config.find(tagKey, tagKey + strlen(tagKey)); | ||
| if (tagConfig) { | ||
| if (!tagConfig->isObject()) { | ||
| PARAM_WARNING_DEFAULT(context.GetLogger(), |
| @@ -475,6 +475,11 @@ void Pipeline::CopyNativeGlobalParamToGoPipeline(Json::Value& pipeline) { | |||
| Json::Value& global = pipeline["global"]; | |||
There was a problem hiding this comment.
这里优化一下吧，这个Copy函数不要从pipeline去调用了，把initglobal函数增加两个入参，就是两个gopipeline，直接在那个里面添加，这样global config里根本不需要存这些参数了，这些参数所有权本来就在tag插件里
There was a problem hiding this comment.
- 整体实现需要重新看一下文档
- 这个插件应该是pipeline级别的了
- C++和Go串联的情况下，应该全部由C++这边来完成处理，Go应该啥都不做，只有Aggregator的Topic是个例外
Comment on lines
+252
to
+258
| if (group.HasMetadata(EventGroupMetaKey::TOPIC)) { | ||
| logGroup.set_topic(group.GetMetadata(EventGroupMetaKey::TOPIC).to_string()); | ||
| } | ||
| for (const auto& tag : group.GetTags()) { | ||
| if (tag.first == LOG_RESERVED_KEY_TOPIC) { | ||
| logGroup.set_topic(tag.second.to_string()); | ||
| } else { | ||
| auto logTag = logGroup.add_logtags(); | ||
| logTag->set_key(tag.first.to_string()); | ||
| logTag->set_value(tag.second.to_string()); | ||
| } | ||
| auto logTag = logGroup.add_logtags(); | ||
| logTag->set_key(tag.first.to_string()); | ||
| logTag->set_value(tag.second.to_string()); |
| @@ -79,7 +79,7 @@ func flushOutStore[T FlushData, F FlusherWrapperInterface](lc *LogstoreConfig, s | |||
| } | |||
|
|
|||
| func loadAdditionalTags(globalConfig *config.GlobalConfig) models.Tags { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持重命名和修改Tag
配置
内部数据结构定义调整