feat: support host monitor #1890
Merged
+1,865
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abingcbc
force-pushed
the
host_monitor
branch
6 times, most recently
from
6150e52 to
bfdd9c2
Compare
messixukejia
requested changes
Nov 25, 2024
henryzhx8
requested changes
Nov 26, 2024
Abingcbc
force-pushed
the
host_monitor
branch
from
4110e3d to
3e12438
Compare
messixukejia
requested changes
Nov 30, 2024
messixukejia
requested changes
Dec 4, 2024
| ThreadPool mThreadPool; | ||
|
|
||
| mutable std::shared_mutex mRegisteredCollectorMapMutex; | ||
| std::unordered_map<std::string, bool> mRegisteredCollectorMap; |
There was a problem hiding this comment.
std::unordered_map<std::string, bool> mRegisteredCollectorMap;
std::unordered_map<std::string, std::shared_ptr<BaseCollector>> mCollectorInstanceMap;
这两个变量有点不合理。
包括
1、HostMonitorInputRunner::GetCollector的使用上。应该是自闭环合法性
2、锁的关系等
3、RegisterCollector 操作的变量是 mCollectorInstanceMap，但是另一个没操作的变量却叫reg
可能的优化
1、保持现有逻辑。一组功能不用过多发散变量，以上改成一个map。value用结构体表示。整体实现结构优化下。
2、UpdateCollector时再注册ProcessEntityCollector实例，这样能省一个变量。
messixukejia
reviewed
Jan 6, 2025
|
|
||
| const std::string ProcessEntityCollector::sName = "process_entity"; | ||
|
|
||
| ProcessEntityCollector::ProcessEntityCollector() : mProcessSilentCount(INT32_FLAG(process_collect_silent_count)) { |
There was a problem hiding this comment.
任务执行异步
超时影响
不同任务类型见例如Prometheus、host entity、processo不影响
There was a problem hiding this comment.
- 线程池放入不会堵塞，runner拿到任务后，可以立刻放入线程池
- 在一个任务执行结束后，再放入下一个任务。一个任务超时，会计算从上一次执行时间开始，增加n个周期，到达下一个未来可执行的时间点。
nextExecTime = execTime + n * interval
messixukejia
requested changes
Jan 7, 2025
core/constants/EntityConstants.cpp
Outdated
| // process entity | ||
| const std::string DEFAULT_CONTENT_VALUE_ENTITY_TYPE_ECS_PROCESS = "acs.ecs.process"; | ||
| const std::string DEFAULT_CONTENT_VALUE_ENTITY_TYPE_HOST_PROCESS = "infra.host.process"; | ||
| const std::string DEFAULT_CONTENT_KEY_PROCESS_PID = "pid"; |
There was a problem hiding this comment.
找讯飞看了一下ebpf那边代码还比较乱，自己维护了一套constant，没有用公共的。
是否可以先合入，然后等ebpf合入后，两边再对齐一下？
messixukejia
requested changes
Jan 7, 2025
henryzhx8
requested changes
Feb 21, 2025
henryzhx8
requested changes
Feb 25, 2025
messixukejia
approved these changes
Feb 26, 2025
|
|
||
| const size_t ProcessTopN = 20; | ||
|
|
||
| const std::string ProcessEntityCollector::sName = "process_entity"; |
henryzhx8
requested changes
Feb 26, 2025
henryzhx8
approved these changes
Feb 27, 2025
messixukejia
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO：