Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the problem of increasing container meta information in Docker Center and add UT to this module #1938

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the problem of increasing container meta information in Docker Center and add UT to this module #1938

wants to merge 1 commit into from
+315 −61

Conversation

linrunqi08
Copy link
Collaborator

@linrunqi08 linrunqi08 commented Dec 2, 2024 •
edited
Loading

  1. 修复之前标准输出C++话引入的finished时间，该时间逻辑为无效逻辑
  2. 修复docker center fetchAll函数返回error问题，现在只有containerList才会返回error，单次inspect失败不会返回error
  3. 修复docker center fetchAll不断重试导致的docker.sock和containerd.sock连接泄漏的问题

@linrunqi08 linrunqi08 force-pushed the feature/taiye/add_docker_test branch from d773980 to c98a4ae Compare December 4, 2024 05:07
@linrunqi08 linrunqi08 force-pushed the feature/taiye/add_docker_test branch from a552757 to e78ef73 Compare December 9, 2024 06:07
yyuuttaaoo
yyuuttaaoo reviewed Dec 11, 2024
View reviewed changes
pkg/helper/docker_center.go
dc.setLastError(err, "inspect container error "+containerID)
return err
}
if !dc.client.ContainerProcessAlive(containerDetail.State.Pid) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exit的直接没机会进map了，会漏采集短job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyuuttaaoo yyuuttaaoo yyuuttaaoo left review comments

@quzard quzard quzard approved these changes

@messixukejia messixukejia Awaiting requested review from messixukejia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linrunqi08 @yyuuttaaoo @quzard