add input_static_file plugin #2063
Open
+2,685
−1,360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messixukejia
reviewed
Feb 3, 2025
| RegisterInputCreator(new StaticInputCreator<InputNetworkObserver>(), true); | ||
| RegisterInputCreator(new StaticInputCreator<InputNetworkSecurity>(), true); | ||
| RegisterInputCreator(new StaticInputCreator<InputProcessSecurity>(), true); | ||
| RegisterInputCreator(new StaticInputCreator<InputContainerStdio>(), false); |
There was a problem hiding this comment.
连续两个bool参数有点太乱了，分不清。
是不是可以考虑把RegisterInputCreator改成两个函数？ONETIME、CONTINUOUS
| if (value.isNull()) { | ||
| hash ^= std::hash<std::string>{}("null"); | ||
| } else if (value.isBool()) { | ||
| hash ^= std::hash<bool>{}(value.asBool()); |
There was a problem hiding this comment.
因为这里实在罗列所有类型，后面如果新增一个，如何类型，如何保证这里不漏改？
例如GetOptionalUInt64Param就是这次新加的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.