Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add types for shell, and move functions from types to utils #1321

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

JackLian
Copy link
Collaborator

@JackLian JackLian commented Dec 4, 2022

No description provided.

@JackLian JackLian requested a review from liujuping as a code owner December 4, 2022 11:36
@JackLian JackLian changed the title feat: add types 【WIP】dont accept feat: add types Dec 4, 2022
@JackLian JackLian marked this pull request as draft December 4, 2022 11:37
@github-actions
Copy link

github-actions bot commented Dec 4, 2022

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 72.51% 889/1226
🟡 Branches 61.86% 558/902
🟡 Functions 69.18% 193/279
🟡 Lines 72.53% 874/1205

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 1a0935d

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.33% 110/330
🔴 Branches 14.29% 23/161
🔴 Functions 26.19% 22/84
🔴 Lines 33.85% 110/325

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 1a0935d

@JackLian JackLian changed the title 【WIP】dont accept feat: add types 【WIP】feat: add types Dec 4, 2022
@github-actions
Copy link

github-actions bot commented Dec 4, 2022

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 97.23% 2949/3033
🟢 Branches 89.63% 1694/1890
🟢 Functions 98.75% 872/883
🟢 Lines 97.39% 2869/2946

Test suite run success

384 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from 1a0935d

@JackLian JackLian changed the title 【WIP】feat: add types feat: add types Dec 4, 2022
@JackLian JackLian force-pushed the feat/add-shell-types branch 3 times, most recently from b6ad754 to 4535cb0 Compare December 5, 2022 12:10
@JackLian JackLian marked this pull request as ready for review December 5, 2022 12:31
@JackLian JackLian requested a review from LeoYuan as a code owner December 5, 2022 12:31
@JackLian JackLian force-pushed the feat/add-shell-types branch from 175cca7 to 1a0935d Compare December 6, 2022 02:10
@liujuping liujuping changed the title feat: add types refactor: add types for shell, and move functions from types to utils Dec 6, 2022
@liujuping liujuping merged commit 55c3fc9 into develop Dec 6, 2022
@liujuping liujuping deleted the feat/add-shell-types branch December 6, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants