refactor: remove dependent of shell from designer #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 97.22% (-0.01% 🔻) |
2938/3022 |
| 🟢 | Branches | 89.65% (+0.02% 🔼) |
1689/1884 |
| 🟢 | Functions | 98.75% (-0% 🔻) |
869/880 |
| 🟢 | Lines | 97.38% (-0.01% 🔻) |
2859/2936 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / designer.ts |
95.15% (-0.2% 🔻) |
81.95% (-0.06% 🔻) |
100% | 95.02% (-0.19% 🔻) |
Test suite run success
384 tests passing in 42 suites.
Report generated by 🧪jest coverage report action from b67105f
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 72.51% | 889/1226 |
| 🟡 | Branches | 61.86% | 558/902 |
| 🟡 | Functions | 69.18% | 193/279 |
| 🟡 | Lines | 72.53% | 874/1205 |
Test suite run success
91 tests passing in 8 suites.
Report generated by 🧪jest coverage report action from b67105f
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 33.33% | 110/330 |
| 🔴 | Branches | 14.29% | 23/161 |
| 🔴 | Functions | 26.19% | 22/84 |
| 🔴 | Lines | 33.85% | 110/325 |
Test suite run success
2 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from b67105f
JackLian
force-pushed
the
refactor/fix-circular-dep
branch
from
c11983b to
82b3527
Compare
JackLian
force-pushed
the
refactor/fix-circular-dep
branch
3 times, most recently
from
199dd71 to
6ba7cc0
Compare
JackLian
force-pushed
the
refactor/fix-circular-dep
branch
from
4bad8b1 to
b67105f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
解除designer对shell的依赖