Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec: support type NodeSchema when the Node is JSSlot #1368

Merged
merged 1 commit into from
Dec 21, 2022
Merged

spec: support type NodeSchema when the Node is JSSlot #1368

merged 1 commit into from
Dec 21, 2022

Conversation

LeoYuan
Copy link
Contributor

@LeoYuan LeoYuan commented Dec 14, 2022

两点修改：

  1. 支持 JSSlot 节点的 value 为一个 NodeSchema 对象，现协议仅支持 NodeSchema[]；
  2. 将 Array 形式改写成 Type[]，这是 TypeScript 推荐的方式；

@liujuping liujuping merged commit 064e842 into develop Dec 21, 2022
@liujuping liujuping deleted the refactor/spec branch December 21, 2022 02:07
@liujuping liujuping changed the title feat(spec): support type NodeSchema when the Node is JSSlot spec: support type NodeSchema when the Node is JSSlot Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liujuping liujuping Awaiting requested review from liujuping liujuping is a code owner

@JackLian JackLian Awaiting requested review from JackLian JackLian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeoYuan @liujuping