Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix onChangeNodeVisible and onChangeNodeChildren api cannot be triggered successfully in some scenarios #1435

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

liujuping
Copy link
Collaborator

fixed #1154

@liujuping liujuping requested a review from JackLian as a code owner January 3, 2023 07:31
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.33% 110/330
🔴 Branches 14.29% 23/161
🔴 Functions 26.19% 22/84
🔴 Lines 33.85% 110/325

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from f7be4eb

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 72.53% 890/1227
🟡 Branches 61.86% 558/902
🟡 Functions 69.29% 194/280
🟡 Lines 72.53% 874/1205

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from f7be4eb

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements
97.21% (-0.2% 🔻)
2826/2907
🟢 Branches 89.18% 1591/1784
🟢 Functions
97.75% (-0.44% 🔻)
867/887
🟢 Lines
97.31% (-0.2% 🔻)
2752/2828
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / document-model.ts
96.44% (-2.64% 🔻)
91.8%
93.75% (-4.93% 🔻)
97.27% (-2.73% 🔻)

Test suite run success

383 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from f7be4eb

@liujuping liujuping force-pushed the fix/document-onChangeNodeChildren branch 2 times, most recently from bfa67c8 to 7d50caf Compare January 3, 2023 08:12
@liujuping liujuping force-pushed the fix/document-onChangeNodeChildren branch from 7d50caf to f7be4eb Compare January 3, 2023 09:37
@JackLian JackLian merged commit 9444752 into develop Jan 3, 2023
@JackLian JackLian deleted the fix/document-onChangeNodeChildren branch January 3, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants