Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add isInLiveEditing api to canvas for refactoring of hotkey plugin as a standalone one #1489

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

JackLian
Copy link
Collaborator

No description provided.

@JackLian JackLian requested a review from liujuping as a code owner January 13, 2023 06:41
@github-actions
Copy link

github-actions bot commented Jan 13, 2023

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.33% 110/330
🔴 Branches 14.29% 23/161
🔴 Functions 26.19% 22/84
🔴 Lines 33.85% 110/325

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from b0045a2

@github-actions
Copy link

github-actions bot commented Jan 13, 2023

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 72.53% 890/1227
🟡 Branches 61.86% 558/902
🟡 Functions 69.29% 194/280
🟡 Lines 72.53% 874/1205

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from b0045a2

@github-actions
Copy link

github-actions bot commented Jan 13, 2023

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 97.09% 2835/2920
🟢 Branches 89.02% 1597/1794
🟢 Functions 97.64% 870/891
🟢 Lines 97.18% 2761/2841

Test suite run success

382 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from b0045a2

@JackLian JackLian force-pushed the refactor/abstract-hotkey-plugin branch 2 times, most recently from 7b13d58 to bb6acd9 Compare January 13, 2023 07:16
@JackLian JackLian force-pushed the refactor/abstract-hotkey-plugin branch from 9a40072 to b0045a2 Compare January 13, 2023 07:47
@liujuping liujuping merged commit f25babe into develop Jan 13, 2023
@liujuping liujuping deleted the refactor/abstract-hotkey-plugin branch January 13, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants