Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: the renderer-core leaf component removes the react.createElement call #1539

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

liujuping
Copy link
Collaborator

@liujuping liujuping commented Feb 7, 2023

feat: the renderer-core leaf component removes the react.createElement call

fixed #835

fixed #575

@liujuping liujuping requested a review from JackLian as a code owner February 7, 2023 09:19
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.93% 114/336
🔴 Branches 14.81% 24/162
🔴 Functions 26.44% 23/87
🔴 Lines 34.55% 114/330

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from be37460

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements
72.38% (-0.15% 🔻)
891/1231
🟡 Branches
61.84% (-0.03% 🔻)
559/904
🟡 Functions 69.29% 194/280
🟡 Lines
72.37% (-0.16% 🔻)
875/1209
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡 renderer/base.tsx
67.3% (-0.22% 🔻)
55.37% (-0.03% 🔻)
64.63%
67.24% (-0.22% 🔻)
🟡
... / renderer.tsx
67.57% (-0.93% 🔻)
40.32% 52.38%
67.57% (-0.93% 🔻)

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from be37460

@liujuping liujuping force-pushed the fix/leaf-remove-react branch from 45c0f35 to 42c6e98 Compare February 7, 2023 09:25
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.64% 2820/2918
🟢 Branches 88.64% 1591/1795
🟢 Functions 96.41% 859/891
🟢 Lines 96.72% 2746/2839

Test suite run success

368 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from be37460

@liujuping liujuping force-pushed the fix/leaf-remove-react branch from 42c6e98 to c80bdc8 Compare February 7, 2023 09:54
@liujuping liujuping force-pushed the fix/leaf-remove-react branch from c80bdc8 to be37460 Compare February 7, 2023 10:09
@JackLian JackLian merged commit c3ce042 into develop Feb 7, 2023
@JackLian JackLian deleted the fix/leaf-remove-react branch February 7, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants