fix: designer i18n locale is not correct #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
CLA麻烦签一下 |
|
@JackLian 请问下 1.0.18 版本的 fix 提交哪个分支呢 |
|
|
哦，好的 |
kbakdev
approved these changes
Feb 14, 2023
|
this.getLocale 可能不是一个 function，需要做一下判断并处理。 |
JackLian
reviewed
Feb 16, 2023
| @@ -830,7 +830,7 @@ export default function baseRendererFactory(): IBaseRenderComponent { | |||
| } | |||
| } | |||
|
|
|||
| const handleI18nData = (innerProps: any) => innerProps[innerProps.use || 'zh-CN']; | |||
| const handleI18nData = (innerProps: any) => innerProps[innerProps.use || this.getLocale && this.getLocale() || 'zh-CN']; | |||
There was a problem hiding this comment.
this.getLocale && this.getLocale()用括号括起来吧, 像这样
innerProps[innerProps.use || (this.getLocale && this.getLocale()) || 'zh-CN'];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.