-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): isReactComponent not including react.memo #1885
Conversation
ChatGPT Code Review: CodeReview: 这个 diff 文件中主要是一些 GitHub Workflows 的修改,以及 utils 包中 is-react.ts 的更新。is-react.ts 的更新解决了一个问题,之前的 isReactComponent 函数没有考虑到 react.memo 组件,现在更新后解决了这个问题。 代码中没有明显的错误和 typo,看起来修改和更新也符合要求。 修改建议:
|
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 33.63% | 114/339 |
🔴 | Branches | 14.88% | 25/168 |
🔴 | Functions | 26.14% | 23/88 |
🔴 | Lines | 34.23% | 114/333 |
Test suite run success
2 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 43c975b
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟡 | Statements | 72% (-0.04% 🔻) |
905/1257 |
🟡 | Branches | 61.23% | 567/926 |
🟡 | Functions | 69.26% (-0.11% 🔻) |
196/283 |
🟡 | Lines | 71.98% (-0.05% 🔻) |
889/1235 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🟢 | hoc/leaf.tsx | 95.79% (-0.04% 🔻) |
85.62% | 100% | 95.69% (-0.04% 🔻) |
Test suite run success
91 tests passing in 8 suites.
Report generated by 🧪jest coverage report action from 43c975b
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 96.34% (-0% 🔻) |
2844/2952 |
🟢 | Branches | 88.79% (-0.05% 🔻) |
1631/1837 |
🟢 | Functions | 95.98% | 859/895 |
🟢 | Lines | 96.41% (-0% 🔻) |
2770/2873 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🟢 | ... / create-simulator.ts |
87.23% (-0.52% 🔻) |
67.65% | 85.71% | 87.23% (-0.52% 🔻) |
🟢 | ... / plugin-context.ts |
100% | 91.67% (-8.33% 🔻) |
100% | 100% |
Test suite run success
370 tests passing in 42 suites.
Report generated by 🧪jest coverage report action from 43c975b
b5188eb
to
f089569
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 48.18% (-51.82% 🔻) |
119/247 |
🔴 | Branches | 42.64% (-57.36% 🔻) |
113/265 |
🔴 | Functions | 41.03% (-58.97% 🔻) |
32/78 |
🔴 | Lines | 49.36% (-50.64% 🔻) |
115/233 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🟢 | build-components.ts | 93.06% | 86.96% | 91.67% | 92.86% |
🟢 | is-es-module.ts | 100% | 100% | 100% | 100% |
🟢 | is-react.ts | 87.5% | 91.3% | 85.71% | 87.5% |
🟢 | clone-enumerable-property.ts | 100% | 100% | 100% | 100% |
🔴 | is-object.ts | 50% | 50% | 50% | 50% |
🟢 | ... / index.ts |
100% | 100% | 100% | 100% |
🔴 | ... / is-action-content-object.ts |
0% | 0% | 0% | 0% |
🔴 | ... / is-custom-view.ts |
0% | 0% | 0% | 0% |
🔴 | ... / is-dom-text.ts |
0% | 100% | 0% | 0% |
🔴 | ... / is-dynamic-setter.ts |
0% | 0% | 0% | 0% |
🔴 | ... / is-i18n-data.ts |
0% | 0% | 0% | 0% |
🟢 | ... / is-jsblock.ts |
100% | 100% | 100% | 100% |
🔴 | ... / is-jsexpression.ts |
0% | 0% | 0% | 0% |
🔴 | ... / is-isfunction.ts |
0% | 0% | 0% | 0% |
🔴 | ... / is-jsslot.ts |
0% | 0% | 0% | 0% |
🔴 | ... / is-lowcode-component-type.ts |
0% | 100% | 0% | 0% |
🔴 | ... / is-procode-component-type.ts |
0% | 100% | 0% | 0% |
🔴 | ... / is-node-schema.ts |
0% | 0% | 0% | 0% |
🔴 | ... / is-project-schema.ts |
0% | 0% | 0% | 0% |
🔴 | ... / is-setter-config.ts |
0% | 0% | 0% | 0% |
🔴 | ... / is-title-config.ts |
0% | 0% | 0% | 0% |
🟡 | is-plain-object.ts | 75% | 40% | 100% | 75% |
🔴 | ... / is-drag-node-data-object.ts |
0% | 0% | 0% | 0% |
🔴 | ... / is-drag-node-object.ts |
0% | 0% | 0% | 0% |
🔴 | ... / is-drag-any-object.ts |
0% | 0% | 0% | 0% |
🔴 | ... / is-location-children-detail.ts |
0% | 0% | 0% | 0% |
🔴 | ... / is-node.ts |
0% | 0% | 0% | 0% |
🔴 | ... / is-location-data.ts |
0% | 0% | 0% | 0% |
🔴 | ... / is-setting-field.ts |
0% | 0% | 0% | 0% |
🟢 | ... / is-lowcode-project-schema.ts |
100% | 50% | 100% | 100% |
🟢 | ... / is-component-schema.ts |
100% | 100% | 100% | 100% |
🔴 | schema.ts | 25.32% | 25.35% | 55.56% | 26.39% |
🔴 | misc.ts | 5% | 5.88% | 5.56% | 5.56% |
Test suite run success
32 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from 43c975b
f089569
to
43c975b
Compare
fixed #1884
fixed #1850