Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): add some api to be compatible with old platforms #1889

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

liujuping
Copy link
Collaborator

No description provided.

@liujuping liujuping requested a review from JackLian as a code owner April 17, 2023 07:52
@github-actions
Copy link

github-actions bot commented Apr 17, 2023

ChatGPT Code Review:

CodeReview:

这次的修改主要是在 common.tsx 中添加了三个函数,分别是 action, engineConfig 和 runInAction。这三个函数都是从 "@alilc/lowcode-editor-core" 中引入的。

在 get 函数中,我们可以看到三个函数都被声明为“@deprecated”,意味着这些函数已经不再推荐使用。虽然在添加 @deprecated 后仍然可以使用这些函数,但是在后续版本中可能会被移除,因此我们应该尽量不使用这些函数。

建议修改:

  1. 检查代码中的注释和文档,确保它们与代码的实际执行一致。

  2. 建议不使用 @deprecated 标记的函数,并寻找其他方法来替代它们。如果真的需要使用这些函数,应该使用 @deprecated 标记时注意到这个函数可能被移除。

  3. 对于注释和文档,应该将它们不断更新以保持最新。特别注意过时的函数或方法,及时更新相关注释和文档。

Commit Message:

feat(common): add compatibility with old platforms

Explanation:
Added action, engineConfig, and runInAction functions to common.tsx for compatibility with old platforms. These functions are marked as @deprecated and should be avoided in favor of newer options.

@github-actions
Copy link

github-actions bot commented Apr 17, 2023

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 48.18% 119/247
🔴 Branches 42.64% 113/265
🔴 Functions 41.03% 32/78
🔴 Lines 49.36% 115/233

Test suite run success

32 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 4d5d91f

@github-actions
Copy link

github-actions bot commented Apr 17, 2023

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.88% 25/168
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 4d5d91f

@github-actions
Copy link

github-actions bot commented Apr 17, 2023

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 72.04% 907/1259
🟡 Branches 61.23% 567/926
🟡 Functions 69.37% 197/284
🟡 Lines 72.03% 891/1237

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 4d5d91f

@github-actions
Copy link

github-actions bot commented Apr 17, 2023

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.34% 2846/2954
🟢 Branches 88.84% 1632/1837
🟢 Functions 95.98% 859/895
🟢 Lines 96.42% 2772/2875

Test suite run success

370 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from 4d5d91f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants