Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve the workspace sleep scene #2043

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

liujuping
Copy link
Collaborator

No description provided.

@liujuping liujuping requested a review from JackLian as a code owner May 17, 2023 09:22
@github-actions
Copy link

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 48.18% 119/247
🔴 Branches 42.64% 113/265
🔴 Functions 41.03% 32/78
🔴 Lines 49.36% 115/233

Test suite run success

32 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from ede78ec

@github-actions
Copy link

ChatGPT Code Review:

  1. 修改建议:
  • 在window.ts文件中,删除第6到10行中的if语句,并调整后续代码;
  • 在workspace.ts文件中,将initWindow方法改为async方法,并在第129行调用await this.window.init()。
  1. 代码功能:
    该代码是针对编辑器工作区的一些改进,具体包括:
  • 在window.ts文件中,如果config中的sleep属性没有设置,则通过调用this.init()方法来初始化编辑器视图。
  • 在workspace.ts文件中,进行了多处改进,包括将initWindow方法改为async方法并在第129行调用await this.window.init()来初始化窗口,调整打开和关闭窗口的方法,以及设置默认窗口等。

@github-actions
Copy link

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.88% 25/168
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from ede78ec

@github-actions
Copy link

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 71.95% 908/1262
🟡 Branches 61.23% 567/926
🟡 Functions 69.12% 197/285
🟡 Lines 71.94% 892/1240

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from ede78ec

@github-actions
Copy link

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.41% 2843/2949
🟢 Branches 89.06% 1628/1828
🟢 Functions 95.97% 858/894
🟢 Lines 96.48% 2770/2871

Test suite run success

370 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from ede78ec

@JackLian JackLian merged commit 059ffe0 into develop May 17, 2023
@JackLian JackLian deleted the feat/workspace-sleep branch May 17, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants