Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update modals visible state in outline pane #2064

Merged
merged 1 commit into from
May 23, 2023

Conversation

liujuping
Copy link
Collaborator

No description provided.

@github-actions
Copy link

ChatGPT Code Review:

  1. 这段代码的 diff 主要做了树形结构节点的可见性逻辑修改,分别修改了 controllers/tree-node.tscontrollers/tree.tsviews/tree-title.tsx 这三个文件。其中,tree-node.ts 文件中新增了一个判断可见性的逻辑,tree.ts 文件中新增了一个接收可见性改变的事件回调函数,tree-title.tsx 文件中也新增了一个处理可见性改变事件的回调函数。
  2. 代码的功能是对树形结构的节点进行可见性的操作,主要集中在 views/tree-title.tsx 文件中,用于控制节点是否可见,以及展示相应图标状态。

@github-actions
Copy link

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 71.95% 908/1262
🟡 Branches 61.23% 567/926
🟡 Functions 69.12% 197/285
🟡 Lines 71.94% 892/1240

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 6c6b987

@github-actions
Copy link

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 48.18% 119/247
🔴 Branches 42.64% 113/265
🔴 Functions 41.03% 32/78
🔴 Lines 49.36% 115/233

Test suite run success

32 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 6c6b987

@github-actions
Copy link

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.88% 25/168
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 6c6b987

@github-actions
Copy link

github-actions bot commented May 23, 2023

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.41% 2843/2949
🟢 Branches 89.06% 1628/1828
🟢 Functions 95.97% 858/894
🟢 Lines 96.48% 2770/2871

Test suite run success

370 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from 6c6b987

@JackLian JackLian merged commit c78dd80 into develop May 23, 2023
@JackLian JackLian deleted the feat/outline-panel-modals branch May 23, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants