Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest adding lifecycle interface, the use of the service optimization nacos and life cycle #1815

Closed
chuntaojun opened this issue Sep 6, 2019 · 8 comments
Closed

Suggest adding lifecycle interface, the use of the service optimization nacos and life cycle #1815

chuntaojun opened this issue Sep 6, 2019 · 8 comments
Assignees
@zongtanghu
Labels
contribution welcome good first issue Good for newcomers
Milestone
1.4.0

Comments

@chuntaojun
Copy link
Collaborator

chuntaojun commented Sep 6, 2019 •
edited
Loading

Issue Description

Type: feature request

Describe what happened (or what feature you want)

background

  1. Because the client instance may exist in the life cycle of the user program running in the process of creating-destroying-creating-destroying
  2. The current client only applies for the management of the thread pool resources. For the client destruction, there is no corresponding shutdown destruction process, which is likely to cause thread pool resource leakage
    Ideas
  3. Create a LifeCycle
  4. The unity of the life cycle inherits it

Describe what you expected to happen

How to reproduce it (as minimally and precisely as possible)

Tell us your environment

Anything else we need to know?
@nacos-bot
Copy link
Collaborator

Hi @chuntaojun, we detect non-English characters in the issue. This comment is an auto translation from @nacos-bot to help other users to understand this issue.
We encourage you to describe your issue in English which is more friendly to other users.

Suggest adding lifecycle interface, the use of the service optimization nacos and life cycle

Issue Description

Type: bug report or feature request

Describe what happened (or what feature you want)

Describe what you expected to happen

How to reproduce it (as minimally and precisely as possible)

Tell us your environment

Anything else we need to know?

@chuntaojun chuntaojun self-assigned this Sep 6, 2019
This was referenced Sep 9, 2019
Closed
Closed
@MistRay MistRay mentioned this issue Nov 14, 2019
Merged
5 tasks
@chuntaojun chuntaojun mentioned this issue Jan 13, 2020
Closed
5 tasks
@chuntaojun
Copy link
Collaborator Author

#2819

@chuntaojun
Copy link
Collaborator Author

#2854

@chuntaojun chuntaojun added this to the 1.3.0 milestone May 22, 2020
@zongtanghu
Copy link
Collaborator

Hi chuntaojun @chuntaojun , this issue can be assign to me , thanks.

@chuntaojun chuntaojun assigned zongtanghu and unassigned chuntaojun May 22, 2020
@chuntaojun
Copy link
Collaborator Author

#2819

@chuntaojun chuntaojun mentioned this issue May 27, 2020
Closed
@yfh0918
Copy link
Contributor

yfh0918 commented May 27, 2020

这个Issue在本次迭代完成吗？

@chuntaojun
Copy link
Collaborator Author

这个Issue在本次迭代完成吗？

You can communicate with @zongtanghu , Current issue is that the student claimed responsibility

@chuntaojun chuntaojun modified the milestones: 1.3.0, 1.4.0 May 27, 2020
@zongtanghu
Copy link
Collaborator

@yfh0918 this issue's pr will be put forward this week.

zongtanghu added a commit to zongtanghu/nacos that referenced this issue May 29, 2020
@zongtanghu
[alibaba#1815]define LifeCycle interface and related abstract class.

Verified

This commit was signed with the committer’s verified signature.
pradyunsg Pradyun Gedam
GPG key ID: DA17C4B29CB32E4B
Verified
Learn about vigilant mode
886fe6d
zongtanghu added a commit to zongtanghu/nacos that referenced this issue May 29, 2020
@zongtanghu
[alibaba#1815]add ResourceLifeCycleManager,adjust some code and fix s…
6981fbc 
…ome unit test cases.
zongtanghu added a commit to zongtanghu/nacos that referenced this issue May 31, 2020
@zongtanghu
[alibaba#1815]add the related lifecycle test cases codes.
6d1baed
@zongtanghu zongtanghu mentioned this issue May 31, 2020
Merged
5 tasks
zongtanghu added a commit to zongtanghu/nacos that referenced this issue May 31, 2020
@zongtanghu
[alibaba#1815]add class file license.
2cb690a
zongtanghu added a commit to zongtanghu/nacos that referenced this issue May 31, 2020
@zongtanghu
[alibaba#1815]add class file license.
ab3b234
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jun 1, 2020
@zongtanghu
[alibaba#1815]adjust codes and reput the lifecycle to ConfigService c…
8d6dd8f 
…lass level.
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jun 2, 2020
@zongtanghu
[alibaba#1815]adjust and optimize codes, reput the lifecycle to Confi…
2ab2742 
…gService class level at the same time.
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jun 3, 2020
@zongtanghu
[alibaba#1815]adjust and optimize codes.
5e2840a
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jun 3, 2020
@zongtanghu
[alibaba#1815]adjust this keywords which just includes constructor an…
09752e3 
…d set method in the class and fix some unit test cases.
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jun 3, 2020
@zongtanghu
[alibaba#1815]fix unit test cases.
94c41e1
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jun 3, 2020
@zongtanghu
[alibaba#1815]remove destroyService from Factory Class.
15fad5d
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jun 4, 2020
@zongtanghu
[alibaba#1815]remove no used package name from Factory Class.
8a2921e
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jun 9, 2020
@zongtanghu
[alibaba#1815]remove no used package name from Factory Class and adju…
8f7fb0f 
…st test cases.
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jun 11, 2020
@zongtanghu
[alibaba#1815]remove lifeCycle, lifeCycleManager, and adjust some rel…
eb39830 
…ated codes.
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jun 11, 2020
@zongtanghu
[alibaba#1815]fix ut.
9b87379
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jun 11, 2020
@zongtanghu
[alibaba#1815]remove code comments.
d2b9806
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jun 11, 2020
@zongtanghu
[alibaba#1815]adjust codes for instance class attribute init.
e7796b3
zongtanghu added a commit to zongtanghu/nacos that referenced this issue Jun 11, 2020
@zongtanghu
[alibaba#1815]adjust, optimize codes and merge some class.
042bd35
yanlinly pushed a commit that referenced this issue Jun 15, 2020
@zongtanghu
Remove dependency of apache-common-lang3 in the client. (#3031)
3f0023a 
* [#3026]remove dependency of apache-common-lang3 in the client.

* [#1815]adjust, optimize codes and merge some class.

* [#3031]adjust some codes.

* [#3031]adjust codes and fix typo.

* [#3031]fix typo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zongtanghu zongtanghu

Labels
contribution welcome good first issue Good for newcomers
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
5 participants
@zongtanghu @yfh0918 @chuntaojun @KomachiSion @nacos-bot