You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
When reading the code, I found that com.alibaba.nacos.config.server.controller.ConfigServletInner#doGetConfig is more difficult to understand and can be optimized.
Remove if (cacheItem != null), reduce if branch.
the first step is to acquire the lock, when lockResult > 0, cacheItem != null is always true.
…op-import-v1
* 'develop' of https://github.com/alibaba/nacos:
Use SafeConstructor to parse yaml configuration for AbstractConfigChangeListener (alibaba#4753)
[ISSUE alibaba#3922] method createServiceIfAbsent in ServiceManager require sync (alibaba#4713)
fix cloning configuration last desc (alibaba#4697)
[ISSUE alibaba#4661]configServletInner#doGetConfig code optimization (alibaba#4666)
Use revision to set version and upgrade to 1.4.2-SNAPSHOT (alibaba#4711)
Revert interceptor all ui problem
Fixalibaba#4701 (alibaba#4703)
delete comment.
fix metadata batch operation may delete instance problem.
Upgrade to 1.4.1 (alibaba#4695)
fixalibaba#4686 (alibaba#4692)
Build nacos console front for 1.4.1 (alibaba#4690)
For checkstyle
fix: fix Jraft WriteRequest type problem.
Add server identity to replace user-agent white list. (alibaba#4683)
Is your feature request related to a problem? Please describe.
When reading the code, I found that
com.alibaba.nacos.config.server.controller.ConfigServletInner#doGetConfig
is more difficult to understand and can be optimized.if (cacheItem != null)
, reduce if branch.the first step is to acquire the lock, when lockResult > 0,
cacheItem != null
is always true.nacos/config/src/main/java/com/alibaba/nacos/config/server/controller/ConfigServletInner.java
Lines 136 to 138 in cfefc28
nacos/config/src/main/java/com/alibaba/nacos/config/server/controller/ConfigServletInner.java
Lines 165 to 167 in cfefc28
nacos/config/src/main/java/com/alibaba/nacos/config/server/controller/ConfigServletInner.java
Lines 205 to 207 in cfefc28
The text was updated successfully, but these errors were encountered: