Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#12231): When inserting and updating configurations in the database, the time-related field values need to be set using the time obtained from the database's built-in time function. #12232

Closed
wants to merge 1 commit into from

Conversation

Bo-Qiu
Copy link
Contributor

@Bo-Qiu Bo-Qiu commented Jun 15, 2024

What is the purpose of the change

XXXXX

fix(#12231 ): When inserting and updating configurations in the database, the time-related field values need to be set using the time obtained from the database's built-in time function.

XX

fix(#12231 ): When inserting and updating configurations in the database, the time-related field values need to be set using the time obtained from the database's built-in time function.

XXXX

fix(#12231 ): When inserting and updating configurations in the database, the time-related field values need to be set using the time obtained from the database's built-in time function.

@Bo-Qiu Bo-Qiu force-pushed the fix/12231 branch 3 times, most recently from 0fd35f4 to 4abeb3f Compare June 15, 2024 16:19
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 94.39528% with 19 lines in your changes missing coverage. Please review.

Project coverage is 68.92%. Comparing base (833e6ca) to head (3245395).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12232      +/-   ##
=============================================
+ Coverage      68.75%   68.92%   +0.16%     
- Complexity      9228     9240      +12     
=============================================
  Files           1264     1266       +2     
  Lines          41187    41394     +207     
  Branches        4363     4366       +3     
=============================================
+ Hits           28318    28529     +211     
+ Misses         10832    10823       -9     
- Partials        2037     2042       +5     
Files Coverage Δ
.../service/capacity/GroupCapacityPersistService.java 81.81% <100.00%> (ø)
...service/capacity/TenantCapacityPersistService.java 81.88% <100.00%> (ø)
...dded/EmbeddedConfigInfoAggrPersistServiceImpl.java 85.52% <100.00%> (+1.94%) ⬆️
...dded/EmbeddedConfigInfoBetaPersistServiceImpl.java 90.97% <100.00%> (+1.37%) ⬆️
...embedded/EmbeddedConfigInfoPersistServiceImpl.java 83.08% <100.00%> (+1.04%) ⬆️
...edded/EmbeddedConfigInfoTagPersistServiceImpl.java 88.23% <100.00%> (+1.56%) ⬆️
...d/EmbeddedHistoryConfigInfoPersistServiceImpl.java 96.34% <100.00%> (+0.62%) ⬆️
...rnal/ExternalConfigInfoBetaPersistServiceImpl.java 93.66% <100.00%> (+0.80%) ⬆️
.../extrnal/ExternalConfigInfoPersistServiceImpl.java 77.47% <100.00%> (+1.03%) ⬆️
...trnal/ExternalConfigInfoTagPersistServiceImpl.java 86.46% <100.00%> (+1.34%) ⬆️
... and 11 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 833e6ca...3245395. Read the comment docs.

@Bo-Qiu Bo-Qiu force-pushed the fix/12231 branch 4 times, most recently from cf6287f to 8a66f62 Compare June 15, 2024 18:36
… database, the time-related field values need to be set using the time obtained from the database's built-in time function.
@Bo-Qiu Bo-Qiu closed this Jun 15, 2024
@Bo-Qiu Bo-Qiu reopened this Jun 15, 2024
@Bo-Qiu Bo-Qiu closed this Jun 15, 2024
@Bo-Qiu Bo-Qiu reopened this Jun 15, 2024
@Bo-Qiu
Copy link
Contributor Author

Bo-Qiu commented Jun 16, 2024

@shiyiyue1102
Hi, please review it when you have time, thx!

@Bo-Qiu Bo-Qiu closed this Jun 18, 2024
@Bo-Qiu Bo-Qiu deleted the fix/12231 branch June 18, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants