[ISSUE#12217] Improve the gray configuration #12501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| private String type; | ||
| @SerializedName("gray_type") | ||
| private String grayType; |
There was a problem hiding this comment.
这个type字段在grayrule上下文中应该是没有歧义的
There was a problem hiding this comment.
在 config_info 里有个 type 字段用来记录配置格式，比如 {"type":"properties"}，现在这个 type 会被记录到his_config_info 表的 ext_info 字段中，这里灰度的 type 也是记录到 ext_info 中去，我感觉这样可能会有歧义，所以就改了一下，不知道这样合不合适
| tenantTmp, grayNameTmp); | ||
| if (oldConfigAllInfo4Gray == null) { | ||
| if (LogUtil.FATAL_LOG.isErrorEnabled()) { | ||
| LogUtil.FATAL_LOG.error("expected config info[dataid:{}, group:{}, tenent:{}] but not found.", |
There was a problem hiding this comment.
这里加个warn日志就行， 不要报error
Maszal2007
reviewed
Sep 6, 2024
|
config/src/main/java/com/alibaba/nacos/config/server/model/ConfigAllInfo4Gray.java |
|
already merge into develop throught another pr， close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Improve the gray configuration, add the historical records of gray configuration changes and adjust the console interface，its closes #12217
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.