Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12555] SwitchManager support http、tcp、mysql HealthParams and pushCSharpVersion update #12574

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

XiaZhouxx
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#12555

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

…rsion update.

2. remove batch update.
3. debug param default is false.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 69.61%. Comparing base (a9a0df2) to head (d9efdfb).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...a/com/alibaba/nacos/naming/misc/SwitchManager.java 0.00% 23 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12574      +/-   ##
=============================================
- Coverage      69.62%   69.61%   -0.02%     
- Complexity      9398     9407       +9     
=============================================
  Files           1275     1275              
  Lines          41161    41190      +29     
  Branches        4366     4369       +3     
=============================================
+ Hits           28657    28673      +16     
- Misses         10428    10436       +8     
- Partials        2076     2081       +5     
Files with missing lines Coverage Δ
...ava/com/alibaba/nacos/naming/misc/SwitchEntry.java 0.00% <ø> (ø)
...baba/nacos/naming/model/form/UpdateSwitchForm.java 48.00% <ø> (ø)
...a/com/alibaba/nacos/naming/misc/SwitchManager.java 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9a0df2...d9efdfb. Read the comment docs.

@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. area/Naming labels Sep 2, 2024
@KomachiSion KomachiSion modified the milestones: 3.0.0, 2.4.2 Sep 2, 2024
@KomachiSion KomachiSion merged commit 821150d into alibaba:develop Sep 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Naming kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants