Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Auth server identity check. #12871

Merged

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@wuyfee
Copy link

wuyfee commented Nov 21, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 97.40260% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.25%. Comparing base (fb68b7e) to head (5928370).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
...baba/nacos/auth/serveridentity/ServerIdentity.java 83.33% 1 Missing ⚠️
...s/common/remote/client/grpc/GrpcClusterClient.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12871      +/-   ##
=============================================
+ Coverage      72.17%   72.25%   +0.08%     
- Complexity      9794     9826      +32     
=============================================
  Files           1283     1287       +4     
  Lines          41387    41445      +58     
  Branches        4374     4373       -1     
=============================================
+ Hits           29869    29948      +79     
+ Misses          9414     9394      -20     
+ Partials        2104     2103       -1     
Files with missing lines Coverage Δ
...libaba/nacos/auth/AbstractProtocolAuthService.java 100.00% <100.00%> (ø)
...om/alibaba/nacos/auth/GrpcProtocolAuthService.java 100.00% <100.00%> (ø)
...om/alibaba/nacos/auth/HttpProtocolAuthService.java 100.00% <100.00%> (ø)
...baba/nacos/auth/serveridentity/DefaultChecker.java 100.00% <100.00%> (ø)
...th/serveridentity/ServerIdentityCheckerHolder.java 100.00% <100.00%> (ø)
...acos/auth/serveridentity/ServerIdentityResult.java 100.00% <100.00%> (ø)
...ba/nacos/common/remote/client/grpc/GrpcClient.java 92.37% <100.00%> (+0.03%) ⬆️
...n/java/com/alibaba/nacos/core/auth/AuthFilter.java 80.00% <100.00%> (+36.06%) ⬆️
...baba/nacos/auth/serveridentity/ServerIdentity.java 83.33% <83.33%> (ø)
...s/common/remote/client/grpc/GrpcClusterClient.java 91.66% <0.00%> (-8.34%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb68b7e...5928370. Read the comment docs.

@KomachiSion KomachiSion merged commit 4be615c into alibaba:develop Nov 21, 2024
7 checks passed
littlesparklet added a commit to littlesparklet/nacos that referenced this pull request Nov 21, 2024
@wuyfee
Copy link

wuyfee commented Nov 21, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

KomachiSion pushed a commit that referenced this pull request Dec 4, 2024
…edirected to the login page without pop-ups. (related issue #11153) (#12907)

* Remove excess code.(related issue #12871 )

* Log in to the console through a browser http://ip:8848/nacos and be redirected to the login page without pop-ups. (related issue #11153)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants