Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "develop-optimize-table" #13126

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Jevgens
Copy link

@Jevgens Jevgens commented Feb 20, 2025

Reverts #13119

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 17 lines in your changes missing coverage. Please review.

Project coverage is 72.33%. Comparing base (1e889ea) to head (3c3008d).

Files with missing lines Patch % Lines
.../config/server/service/ConfigOperationService.java 66.66% 8 Missing and 5 partials ⚠️
.../server/service/ConfigGrayModelMigrateService.java 0.00% 3 Missing ⚠️
...cos/config/server/controller/ConfigController.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #13126      +/-   ##
=============================================
+ Coverage      72.27%   72.33%   +0.05%     
- Complexity     10032    10035       +3     
=============================================
  Files           1310     1310              
  Lines          42016    42018       +2     
  Branches        4416     4414       -2     
=============================================
+ Hits           30367    30392      +25     
+ Misses          9555     9523      -32     
- Partials        2094     2103       +9     
Files with missing lines Coverage Δ
...cos/config/server/controller/ConfigController.java 69.43% <88.88%> (+0.36%) ⬆️
.../server/service/ConfigGrayModelMigrateService.java 0.00% <0.00%> (-0.65%) ⬇️
.../config/server/service/ConfigOperationService.java 74.82% <66.66%> (-4.31%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e889ea...3c3008d. Read the comment docs.

@KomachiSion
Copy link
Collaborator

Why revert #13119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants