Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 2827]: hotfix config dump #2828

Merged
merged 5 commits into from
May 21, 2020
Merged

[ISSUE 2827]: hotfix config dump #2828

merged 5 commits into from
May 21, 2020

Conversation

chuntaojun
Copy link
Collaborator

@chuntaojun chuntaojun commented May 19, 2020

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#2827

Brief changelog

Because of the spring for Bean initialization is single-threaded serial execution, so if in the heart of the initialization process due to some time consuming to initialize an asynchronous operation, may container startup when the operation is not yet complete, so need to consider to add a Reporter, for loops callback to judge whether the initialization of an asynchronous operation has been completed

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@chuntaojun chuntaojun changed the title fix: fix config dump [ISSUE 2827]: hotfix config dump May 19, 2020
@yanlinly yanlinly merged commit 405e2c8 into develop May 21, 2020
@chuntaojun chuntaojun deleted the hotfix_config_dump branch June 2, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants