[#3063] fixed parameter validation boundary problem #3064
Merged
+18
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yanlinly
reviewed
Jun 15, 2020
| public final class ValidatorUtils { | ||
|
|
||
| private static final Pattern CONTEXT_PATH_MATCH = Pattern.compile("(\\/)\\1+"); | ||
| private static final Pattern IP_MATCH = Pattern.compile("([^\\/:]+)(:\\d+)"); | ||
|
|
||
| public static void checkInitParam(Properties properties) { | ||
| final String severAddrs = properties.getProperty(PropertyKeyConst.SERVER_ADDR); |
There was a problem hiding this comment.
加这个校验的原因是？ 因为底层也是有一些简单判断是否为空的校验的。当时加这个校验的issue是？
构造serverlistmanager的时候底层有校验
if (StringUtils.isBlank(endpoint)) {
throw new NacosException(NacosException.CLIENT_INVALID_PARAM, "endpoint is blank");
}
yanlinly
reviewed
Jun 15, 2020
client/src/main/java/com/alibaba/nacos/client/utils/ValidatorUtils.java
Outdated
Show resolved
Hide resolved
yanlinly
reviewed
Jun 15, 2020
client/src/main/java/com/alibaba/nacos/client/utils/ValidatorUtils.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
#3063
#2978
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.