Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert interceptor all ui problem #4708

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

KomachiSion
Copy link
Collaborator

@KomachiSion KomachiSion commented Jan 15, 2021

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

For #4701.

Found if interceptor all un register api, ui will be interceptor too.

so only add '/' support in methodCache first.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Copy link
Collaborator

@lzp0412 lzp0412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yimao
Copy link

yimao commented Jan 27, 2021

需要注意的是 TAG 1.4.1 (Jan 15, 2021) 并不包括 #4708 这次提交,用户依然需要基于1.4.1 tag 手动合并 #4708 改动,然后重新打包部署才能解决首页访问 404 的问题。

@zxhans
Copy link

zxhans commented Mar 23, 2021

不单是首页,client的jar 1.4.1里面,contextPath=/nacos 这个contextPath整个都丢了,变成了“”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants