feat: modularize rule #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y1yang0
force-pushed
the
yyang/new_mod_rule
branch
14 times, most recently
from
83ff935 to
0ab0a72
Compare
y1yang0
force-pushed
the
yyang/new_mod_rule
branch
5 times, most recently
from
329c0ce to
ebfbf9e
Compare
This was
linked to
issues
Oct 23, 2024
Closed
y1yang0
force-pushed
the
yyang/new_mod_rule
branch
2 times, most recently
from
0abe068 to
48a0a79
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 64.01% 0.00% -64.02%
==========================================
Files 22 1 -21
Lines 992 17 -975
==========================================
- Hits 635 0 -635
+ Misses 332 17 -315
+ Partials 25 0 -25 ☔ View full report in Codecov by Sentry. |
|
The test always fails with |
y1yang0
force-pushed
the
yyang/new_mod_rule
branch
3 times, most recently
from
09600ae to
5d73875
Compare
|
All tests passed! Could I have a review? @123liuziming @yanglong1010 |
| example/demo/demo | ||
| test/zap/test_zap | ||
| test/gorm/v1.22.0/test_gorm_crud |
There was a problem hiding this comment.
I believe there are more binaries to ignore
There was a problem hiding this comment.
Yes, let's add them when we need to
There was a problem hiding this comment.
The plugin tests should be runned in Go1.22 and Go1.23 now according to the latest otel sdk
y1yang0
force-pushed
the
yyang/new_mod_rule
branch
from
5d73875 to
9e69d33
Compare
123liuziming
approved these changes
Oct 29, 2024
Co-authored-by: 牧思 <liuziming.lzm@alibaba-inc.com>
y1yang0
force-pushed
the
yyang/new_mod_rule
branch
from
9e69d33 to
d48aa44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete #35 #44
Fix #133
This patch allows us to load any rules, including user-defined ones, at compile time.