Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polish make claen && make build #233

Merged
merged 2 commits into from
Nov 29, 2024
Merged

polish make claen && make build #233

merged 2 commits into from
Nov 29, 2024

Conversation

JaredTan95
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

y1yang0
y1yang0 reviewed Nov 29, 2024
View reviewed changes
Copy link
Member

@y1yang0 y1yang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit here: build task ought to be first so that make is equivalent to make build

@NameHaibinZhang NameHaibinZhang self-requested a review November 29, 2024 01:50
@JaredTan95
Copy link
Contributor Author

One nit here: build task ought to be first so that make is equivalent to make build

update

@y1yang0 y1yang0 merged commit 2ef0d50 into alibaba:main Nov 29, 2024
9 checks passed
@JaredTan95 JaredTan95 deleted the polish_makefile branch November 29, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y1yang0 y1yang0 y1yang0 approved these changes

@NameHaibinZhang NameHaibinZhang NameHaibinZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JaredTan95 @CLAassistant @y1yang0 @NameHaibinZhang