fix: OtelRules initialized to wrong path #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
=======================================
Coverage 82.86% 82.86%
=======================================
Files 24 24
Lines 1033 1033
=======================================
Hits 856 856
Misses 144 144
Partials 33 33 ☔ View full report in Codecov by Sentry. |
y1yang0
force-pushed
the
yyang/fixload
branch
3 times, most recently
from
6cced09 to
16cc1be
Compare
y1yang0
force-pushed
the
yyang/fixload
branch
from
16cc1be to
09db4af
Compare
tool/preprocess/preprocess.go
Outdated
| @@ -867,7 +873,7 @@ func (dp *DepProcessor) setupDeps() error { | |||
| return err | |||
| } | |||
|
|
|||
| // Run go mod tidy first to fetch all dependencies | |||
| // Run go mod t idy first to fetch all dependencies | |||
There was a problem hiding this comment.
Better to fix the comment
There was a problem hiding this comment.
Good catch! Let me fix it then.
NameHaibinZhang
approved these changes
Feb 10, 2025
minimAluminiumalism
pushed a commit
to minimAluminiumalism/opentelemetry-go-auto-instrumentation
that referenced
this pull request
Feb 20, 2025
* fix: OtelRules initialized to wrong path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #291
I made mistakes on otel_rules initialization and corresponding removal, I need to revise it