feature: add cpu period and quota for containers #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
force-pushed
the
add-cpu-options
branch
6 times, most recently
from
8002a71 to
ce44269
Compare
Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
allencloud
force-pushed
the
add-cpu-options
branch
from
ce44269 to
5940044
Compare
Codecov Report
@@ Coverage Diff @@
## master #1067 +/- ##
==========================================
+ Coverage 16.48% 16.48% +<.01%
==========================================
Files 158 159 +1
Lines 8841 8783 -58
==========================================
- Hits 1457 1448 -9
+ Misses 7281 7231 -50
- Partials 103 104 +1
|
Ace-Tang
reviewed
Apr 8, 2018
| @@ -28,3 +28,25 @@ func setupCgroupCPUSet(ctx context.Context, meta *ContainerMeta, spec *SpecWrapp | |||
| cpu.Mems = meta.HostConfig.CpusetMems | |||
| return nil | |||
| } | |||
|
|
|||
| func setupCgroupCPUPeriod(ctx context.Context, meta *ContainerMeta, spec *SpecWrapper) error { | |||
There was a problem hiding this comment.
as I said in #1031, this kind of spec implement not very good, like this fucntion, if s.Linux.Resources.CPU == nil has been judged twice here, or maybe more times in other function.
These commit has no related with this pr.
There was a problem hiding this comment.
Thanks a lot for your comment. I totally agree with you. Spec related construction needs refactoring.
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com
Ⅰ. Describe what this PR did
This adds
--cpu-quotaand--cpu-periodto container options.--cpu-periodshould be in range [1000,1000000], and--cpu-quotashould be in [1000, ∞).Ⅱ. Does this pull request fix one issue?
fixes #1031
Ⅲ. Describe how you did it
none
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none