refactor: move pkg to correct places #1147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com
Ⅰ. Describe what this PR did
When I am learning the structure of package pkg, I find that there are at least three packages which should be moved out of it:
Here is my reason:
we usually keep totally general packages in package pkg, while three packages above are something specific, client is for control server or something like that, quota for filesystem quota for container, and runconfig is for pouch container's some kind of config parameter.
I wish we could add a folder which is named storage, then some structure may be like:
Actually I am afraid the package name of client is not my dishes. Like the code makes me feel confused:
Here, I think client is a struct instance, however it is a package. So hard to understand and quite awkward.
Ⅱ. Does this pull request fix one issue?
fix #1051
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews