-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add publish-all cli flag #2545
feature: add publish-all cli flag #2545
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2545 +/- ##
==========================================
- Coverage 69.18% 69.02% -0.17%
==========================================
Files 278 278
Lines 18565 18607 +42
==========================================
- Hits 12844 12843 -1
- Misses 4262 4293 +31
- Partials 1459 1471 +12
|
c673c9c
to
573e296
Compare
4b709ef
to
ff44374
Compare
This is the only CI failure in integration test:
@ZYecho I think it is related to the code change. |
88272eb
to
ca1bfbc
Compare
Thanks, fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a litter suggestions.
ca1bfbc
to
fa7282e
Compare
Signed-off-by: zhangyue <zy675793960@yeah.net>
fa7282e
to
4c12f8a
Compare
LGTM |
Thanks a lot for your work. @ZYecho |
Signed-off-by: zhangyue zy675793960@yeah.net
Ⅰ. Describe what this PR did
add cli publish all flag to support publish all expose port.
Ⅱ. Does this pull request fix one issue?
fix #2517
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
add a integration test.
Ⅳ. Describe how to verify it
pouch run -d -P redis
to get a publish all container.
pouch inspect cefab5
Got the random port
use
lsof
to verifylsof -iTCP | grep pouch
Got
pouchd 15090 root 16u IPv6 265330 0t0 TCP *:32768 (LISTEN)
Ⅴ. Special notes for reviews
None.