test: update the existing tag image case #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2547 +/- ##
==========================================
+ Coverage 69.11% 69.11% +<.01%
==========================================
Files 278 278
Lines 18528 18528
==========================================
+ Hits 12805 12806 +1
+ Misses 4259 4256 -3
- Partials 1464 1466 +2
|
rudyfly
reviewed
Dec 10, 2018
| resp, err := suite.sendRequest(busyboxImage, repo, tag) | ||
| c.Assert(err, check.IsNil) | ||
| CheckRespStatus(c, resp, 201) | ||
| defer DelImageForceOk(c, tagRef) |
There was a problem hiding this comment.
the tagRef image is created by the case. If we don't delete it, re-run this case will fail. It just is used to clean up.
There was a problem hiding this comment.
But the busyboxImage also will be remain, dont need to delele it？
There was a problem hiding this comment.
busyboxImage is created for the case suite and basically, all suites are related to this image. Therefore, we don't need to delete it.
The TestImageTagFailToOverrideExistingTag tests the case that it will fail to use existing tag name to override existing tag. Signed-off-by: Wei Fu <fuweid89@gmail.com>
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wei Fu fuweid89@gmail.com
Ⅰ. Describe what this PR did
The TestImageTagFailToOverrideExistingTag tests the case that it will
fail to use existing tag name to override existing tag.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
update existing case
Ⅳ. Describe how to verify it
wait for CI
Ⅴ. Special notes for reviews