test: skip the flay case #2686
Merged
test: skip the flay case #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2686 +/- ##
==========================================
+ Coverage 58.9% 69.3% +10.39%
==========================================
Files 276 278 +2
Lines 17361 17392 +31
==========================================
+ Hits 10227 12053 +1826
+ Misses 5934 4015 -1919
- Partials 1200 1324 +124
|
When the init process in a container exits, the pouchcontainer daemon will handle the cleanup job, such as update status code, delete the containerd's task/container record. The action is handled in the goroutine. Since pouchcontainer doesn't lock the whole container, when the status has been updated from `running` into `stopped`, the containerd's task/container records are not removed by the cleanup job. if the user wants to use `wait` command to make sure that cleanup job has been done, it will fail because the status is updated first. The flaky case is running on this case. We can run it until we have better solutions to make the status notification more stable. Signed-off-by: Wei Fu <fuweid89@gmail.com>
|
lgtm |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wei Fu fuweid89@gmail.com
Ⅰ. Describe what this PR did
When the init process in a container exits, the pouchcontainer daemon
will handle the cleanup job, such as update status code, delete the
containerd's task/container record. The action is handled in the
goroutine. Since pouchcontainer doesn't lock the whole container, when
the status has been updated from
runningintostopped, thecontainerd's task/container records are not removed by the cleanup job.
if the user wants to use
waitcommand to make sure that cleanup jobhas been done, it will fail because the status is updated first.
The flaky case is running on this case. We can run it until we have
better solutions to make the status notification more stable.
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
no need
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews