Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: search the images from specific registry #2850

Merged
merged 1 commit into from
Jun 2, 2019

Conversation

hellolijj
Copy link
Contributor

Signed-off-by: Junjun Li junjunli666@gmail.com

Ⅰ. Describe what this PR did

add feature: pouch support search the images from specific registry

Ⅱ. Does this pull request fix one issue?

[feature] pouch cli supports search image

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

pouch search nginx
pouch search nginx -r https://a.b.com

Ⅴ. Special notes for reviews

1、add parameters in /images/search api
2、are these test cases reasonable?

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #2850 into master will decrease coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2850      +/-   ##
==========================================
- Coverage   69.09%   69.03%   -0.07%     
==========================================
  Files         285      286       +1     
  Lines       17844    17889      +45     
==========================================
+ Hits        12330    12349      +19     
- Misses       4114     4130      +16     
- Partials     1400     1410      +10
Flag Coverage Δ
#criv1alpha2_test 38.86% <0%> (-0.15%) ⬇️
#integration_test_0 36.49% <0%> (-0.08%) ⬇️
#integration_test_1 35.34% <35.41%> (-0.42%) ⬇️
#integration_test_2 36.55% <0%> (+0.08%) ⬆️
#integration_test_3 35.42% <39.58%> (-0.03%) ⬇️
#node_e2e_test 34.61% <0%> (-0.16%) ⬇️
#unittest 28.53% <27.08%> (ø) ⬆️
Impacted Files Coverage Δ
client/image_search.go 100% <100%> (ø)
apis/server/image_bridge.go 78.46% <33.33%> (+3.05%) ⬆️
daemon/mgr/image.go 59.89% <61.53%> (+0.44%) ⬆️
pkg/streams/utils.go 82.14% <0%> (-7.15%) ⬇️
ctrd/watch.go 72.97% <0%> (-5.41%) ⬇️
apis/server/utils.go 71.15% <0%> (-3.85%) ⬇️
pkg/meta/store.go 67.44% <0%> (-1.56%) ⬇️
daemon/mgr/container_utils.go 76.76% <0%> (-1.02%) ⬇️
daemon/mgr/container.go 59.72% <0%> (-0.63%) ⬇️
cri/v1alpha2/cri.go 68.81% <0%> (-0.26%) ⬇️
... and 4 more

cli/search.go Outdated Show resolved Hide resolved
cli/search.go Outdated Show resolved Hide resolved
client/image_search.go Outdated Show resolved Hide resolved
client/interface.go Outdated Show resolved Hide resolved
test/cli_search_test.go Outdated Show resolved Hide resolved
daemon/mgr/image.go Outdated Show resolved Hide resolved
daemon/mgr/image.go Show resolved Hide resolved
client/image_search_test.go Show resolved Hide resolved
client/image_search.go Outdated Show resolved Hide resolved
apis/swagger.yml Outdated Show resolved Hide resolved
@hellolijj
Copy link
Contributor Author

this is my first time to add a feature. i attend to accomplish it step by step.
So, there are many things to be improved. please point it out. thanks a lot 😄

daemon/mgr/image.go Outdated Show resolved Hide resolved
daemon/mgr/image.go Outdated Show resolved Hide resolved
daemon/mgr/image.go Outdated Show resolved Hide resolved
daemon/mgr/image.go Outdated Show resolved Hide resolved
registry/config.go Outdated Show resolved Hide resolved
daemon/mgr/image.go Outdated Show resolved Hide resolved
daemon/mgr/image.go Outdated Show resolved Hide resolved
apis/swagger.yml Outdated Show resolved Hide resolved
apis/swagger.yml Outdated Show resolved Hide resolved
apis/server/image_bridge.go Outdated Show resolved Hide resolved
daemon/mgr/image.go Outdated Show resolved Hide resolved
@ZYecho
Copy link
Contributor

ZYecho commented May 28, 2019

@hellolijj any update? lack of integration test now.

@hellolijj
Copy link
Contributor Author

all right, i will add it today

@allencloud allencloud changed the title Search the images from specific registry feature: search the images from specific registry May 28, 2019
test/cli_search_test.go Outdated Show resolved Hide resolved
test/cli_search_test.go Outdated Show resolved Hide resolved
test/cli_search_test.go Outdated Show resolved Hide resolved
test/cli_search_test.go Outdated Show resolved Hide resolved
test/cli_search_test.go Outdated Show resolved Hide resolved
test/cli_search_test.go Outdated Show resolved Hide resolved
@ZYecho
Copy link
Contributor

ZYecho commented May 29, 2019

LGTM

# Conflicts:
#	daemon/mgr/image.go
@allencloud
Copy link
Collaborator

Thanks for your great work. @hellolijj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants