Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: pouch run supports --env-file #2857 #2863

Closed
wants to merge 5 commits into from
Closed

feature: pouch run supports --env-file #2857 #2863

wants to merge 5 commits into from

Conversation

lang710
Copy link
Contributor

@lang710 lang710 commented May 24, 2019

Ⅰ. Describe what this PR did

pouch run supports --env-file

Ⅱ. Does this pull request fix one issue?

fixes #2857

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

don't like

Ⅳ. Describe how to verify it

pouch run --env-file=/home/abc -d busybox top

b2f0df7176e9459441276c7470ad95ae701329b49ff2709344706316597ce639

[root@vm_centos pouch]# pouch exec b2f0df7176e9459441276c7470ad95ae701329b49ff2709344706316597ce639 env | grep env_var_name
env_var_name=another_value

Ⅴ. Special notes for reviews

lang710 added 3 commits May 23, 2019 06:35
Signed-off-by: lang chi <21860405@zju.edu.cn>
Signed-off-by: lang chi <21860405@zju.edu.cn>
Signed-off-by: lang chi <21860405@zju.edu.cn>
@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #2863 into master will decrease coverage by 2.8%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2863      +/-   ##
==========================================
- Coverage   69.09%   66.29%   -2.81%     
==========================================
  Files         285      285              
  Lines       17844    17844              
==========================================
- Hits        12330    11830     -500     
- Misses       4114     4592     +478     
- Partials     1400     1422      +22
Flag Coverage Δ
#criv1alpha2_test 38.96% <ø> (-0.05%) ⬇️
#integration_test_0 ?
#integration_test_1 35.72% <ø> (-0.04%) ⬇️
#integration_test_2 36.48% <ø> (+0.01%) ⬆️
#integration_test_3 35.41% <ø> (-0.04%) ⬇️
#node_e2e_test ?
#unittest 28.53% <ø> (ø) ⬆️
Impacted Files Coverage Δ
hookplugins/containerplugin/update_hook.go 0% <0%> (-100%) ⬇️
cri/stream/remotecommand/websocket.go 0% <0%> (-81.54%) ⬇️
daemon/mgr/container_upgrade.go 0% <0%> (-65.1%) ⬇️
builder/exporter.go 0% <0%> (-62.5%) ⬇️
cri/stream/remotecommand/exec.go 36.66% <0%> (-43.34%) ⬇️
storage/plugins/plugins.go 25% <0%> (-25%) ⬇️
daemon/builder.go 56.25% <0%> (-18.75%) ⬇️
pkg/utils/random_string.go 63.63% <0%> (-18.19%) ⬇️
daemon/mgr/container_envs.go 0% <0%> (-15.79%) ⬇️
daemon/mgr/spec_linux.go 64.66% <0%> (-14.49%) ⬇️
... and 35 more

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to pouch, @lang710
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@CLAassistant
Copy link

CLAassistant commented May 24, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

lang710 added 2 commits May 24, 2019 19:07
Signed-off-by: lang chi <21860405@zju.edu.cn>
Signed-off-by: lang chi <21860405@zju.edu.cn>
@allencloud
Copy link
Collaborator

Thanks for your work. Could you please squash the commits into a single one and check the ci failures? @lang710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pouch run support --env-file
5 participants