Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish api.Tracer with new error tracing mechanism #153

Merged
merged 2 commits into from
May 22, 2020

Conversation

sczyh30
Copy link
Member

@sczyh30 sczyh30 commented May 22, 2020

Signed-off-by: Eric Zhao sczyh16@gmail.com

Describe what this PR does / why we need it

Polish api.Tracer with new error tracing mechanism (set error to entry and record on request completed).

Does this pull request fix one issue?

Related to #143

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30 sczyh30 added the kind/enhancement Category issues or PRs related to enhancement label May 22, 2020
@sczyh30 sczyh30 requested a review from louyuting May 22, 2020 02:27
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2020

Codecov Report

Merging #153 into master will decrease coverage by 0.06%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   41.64%   41.57%   -0.07%     
==========================================
  Files          68       68              
  Lines        3314     3495     +181     
==========================================
+ Hits         1380     1453      +73     
- Misses       1799     1906     +107     
- Partials      135      136       +1     
Impacted Files Coverage Δ
adapter/dubbo/consumer_filter.go 48.38% <0.00%> (ø)
adapter/dubbo/provider_filter.go 48.38% <0.00%> (ø)
api/tracer.go 37.50% <66.66%> (+1.78%) ⬆️
adapter/grpc/client.go 92.59% <100.00%> (ø)
adapter/grpc/server.go 84.00% <100.00%> (ø)
core/flow/tc_throttling.go 66.66% <0.00%> (-11.12%) ⬇️
core/circuitbreaker/rule.go 88.73% <0.00%> (-3.65%) ⬇️
core/circuitbreaker/stat_slot.go 0.00% <0.00%> (ø)
core/circuitbreaker/circuit_breaker.go 23.87% <0.00%> (+0.56%) ⬆️
core/circuitbreaker/rule_manager.go 53.24% <0.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112f169...b603334. Read the comment docs.

api/tracer.go Outdated Show resolved Hide resolved
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@louyuting louyuting merged commit 46b892a into master May 22, 2020
@sczyh30 sczyh30 deleted the polish-tracer-200522 branch May 22, 2020 02:57
@sczyh30 sczyh30 added this to the 0.3.0 milestone Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or PRs related to enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants