Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split isolation pkg to implement concurrency traffic control #247

Merged
merged 2 commits into from
Sep 23, 2020

Conversation

louyuting
Copy link
Collaborator

Describe what this PR does / why we need it

split isolation pkg to implement concurrency traffic control

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2020

Codecov Report

Merging #247 into master will decrease coverage by 0.16%.
The diff coverage is 36.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   42.30%   42.14%   -0.17%     
==========================================
  Files          74       77       +3     
  Lines        3732     3834     +102     
==========================================
+ Hits         1579     1616      +37     
- Misses       1916     1977      +61     
- Partials      237      241       +4     
Impacted Files Coverage Δ
core/base/result.go 26.53% <0.00%> (-0.56%) ⬇️
core/isolation/rule.go 0.00% <0.00%> (ø)
core/isolation/slot.go 0.00% <0.00%> (ø)
core/isolation/rule_manager.go 54.54% <54.54%> (ø)
api/slot_chain.go 80.00% <100.00%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5bbaa1...787d437. Read the comment docs.

@louyuting louyuting requested a review from sczyh30 September 22, 2020 14:58
@louyuting louyuting added area/flow-control Issues or PRs related to flow control kind/feature Category issues or PRs related to feature request to-review PRs to review labels Sep 22, 2020
@sczyh30 sczyh30 added kind/refactor Issue related to functional refactoring. and removed kind/feature Category issues or PRs related to feature request labels Sep 22, 2020
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 4162e79 into alibaba:master Sep 23, 2020
@sczyh30 sczyh30 removed the to-review PRs to review label Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/flow-control Issues or PRs related to flow control kind/refactor Issue related to functional refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "isolation" package and move out concurrency limiting from flow pkg to isolation pkg
4 participants