Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine pooled EntryOptions management #277

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

luckyxiaoqiang
Copy link
Collaborator

Describe what this PR does / why we need it

Refine pooled EntryOptions management by putting it to pool at where we get it. Otherwise, it would be difficult to track its life cycle and not benefit to future maintenance.

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #277 into master will decrease coverage by 0.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   51.45%   51.20%   -0.25%     
==========================================
  Files          79       79              
  Lines        4033     4035       +2     
==========================================
- Hits         2075     2066       -9     
- Misses       1668     1679      +11     
  Partials      290      290              
Impacted Files Coverage Δ
api/api.go 20.28% <0.00%> (-14.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908210d...0f02840. Read the comment docs.

@louyuting louyuting self-requested a review October 12, 2020 02:55
@louyuting louyuting added the kind/enhancement Category issues or PRs related to enhancement label Oct 12, 2020
@louyuting louyuting added this to the 1.0.0 milestone Oct 12, 2020
Copy link
Collaborator

@louyuting louyuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution and look forward for more!

@louyuting louyuting merged commit cb639b4 into alibaba:master Oct 12, 2020
@luckyxiaoqiang luckyxiaoqiang deleted the refine_entryoptions branch December 27, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or PRs related to enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants