feat: hotspot rule add paramKey; #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louyuting
added
area/flow-hotspot
louyuting
reviewed
Jan 14, 2021
cafra
force-pushed
the
hotspot_rule_add_paramKey
branch
from
721845c to
ffa0195
Compare
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
==========================================
- Coverage 51.42% 51.33% -0.09%
==========================================
Files 70 70
Lines 4331 4356 +25
==========================================
+ Hits 2227 2236 +9
- Misses 1806 1818 +12
- Partials 298 302 +4
Continue to review full report at Codecov.
|
louyuting
reviewed
Jan 14, 2021
louyuting
reviewed
Jan 14, 2021
chore:ParamKey add supplementary explanation chore:adjust the order of extraction parameters, give priority to paramkey, and avoid the problem of paramIndex default value 0;update test unit
cafra
force-pushed
the
hotspot_rule_add_paramKey
branch
from
ffa0195 to
f33b480
Compare
liqiangz
reviewed
Jan 15, 2021
louyuting
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the hotspot parameter rule, ParamKey is added to cooperate with the context attachments map to quickly specify the value that requires hotspot current limit from a large number of key-value pairs.
(#360)
Describe what this PR does / why we need it
It is convenient to specify hot spot parameters in hot spot current limiting rules. For example, there are a lot of data for system parameters, calibration parameters in header, and business parameters, and the parameters required by different businesses are different. It is very convenient to add all the data into ctx.attachments and specify the key in the rules.
Does this pull request fix one issue?
This time pr has added ParamKey, and modified the corresponding unit test and example.
Describe how you did it
ParamKey is added to the rule; trafficShaper also implements the extractArg interface correspondingly, which can be used with the existing paramIndex to easily specify hotspot parameters.
Describe how to verify it
Verified in unit test and example
Special notes for reviews
ParamKey can be considered as []string, so that users can specify hotspot rules flexibly in addition to specifying a single parameter.
For example, ParamKey=[]string{"uid","merchant_id"} This allows uid and merchant_id to be used as joint parameters as hot spots.