Unify general configuration and logging configuration #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louyuting
added
area/configuration
louyuting
force-pushed
the
unify_configuration
branch
2 times, most recently
from
64106d0 to
ec700ed
Compare
louyuting
force-pushed
the
unify_configuration
branch
from
ec700ed to
66b7733
Compare
sczyh30
reviewed
Mar 7, 2020
louyuting
force-pushed
the
unify_configuration
branch
from
66b7733 to
9ac2882
Compare
louyuting
force-pushed
the
unify_configuration
branch
from
9ac2882 to
267b7d5
Compare
rearrange related code
louyuting
force-pushed
the
unify_configuration
branch
from
267b7d5 to
6615673
Compare
|
Nice work. Thanks! |
sczyh30
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
unify configuration
Describe how you did it
The priority is: env > yaml > default
That is say, yaml config will override default config and env config will override yaml config.
There is only one parameter "config path" for sentinel initialization. If user don't indicate config path, sentinel will use default config.
Unifying the constant to core/constant, including configuration、global constant variable.
FIX #42
Describe how to verify it
Special notes for reviews