Add dubbogo adapter #60
Conversation
|
|
sczyh30
added
area/integrations
|
Could you please sign the CLA here: https://cla-assistant.io/alibaba/sentinel-golang?pullRequest=60 |
adapter/dubbogo/consumer_filter.go
Outdated
| } | ||
|
|
||
| func (d *consumerFilter) OnResponse(result protocol.Result, _ protocol.Invoker, _ protocol.Invocation) protocol.Result { | ||
| return result |
There was a problem hiding this comment.
Actually, when the invocation completes (whether successful or with error), we need to call e.Exit() to mark it as completed, or the response time, complete count and error count will be lost. We may need to carry the *SentinelEntry in the RPC context (if possible) and handle it in OnResponse callback.
There was a problem hiding this comment.
please check it
adapter/dubbogo/consumer_filter.go
Outdated
| sentinel.WithTrafficType(base.Outbound), | ||
| sentinel.WithArgs(invocation.Attachments())) | ||
| if b != nil { // blocked | ||
| result := &protocol.RPCResult{} |
There was a problem hiding this comment.
Can we also provide a fallback registry where developers could register their own fallback logic when blocked? We could provide the default behavior.
There was a problem hiding this comment.
please check it
| return consumerDubboFallback(ctx, invoker, invocation, b) | ||
| } | ||
| } else { | ||
| // TODO : Need to implement asynchronous current limiting |
There was a problem hiding this comment.
What're the differences between async and sync mode?
There was a problem hiding this comment.
This is mainly to see that in Java code, async entry is used instead of entry to restrict current. At this stage, Dubbo go has not added async field in attachment, so it will not come to async logic
There was a problem hiding this comment.
Okay. Sentinel Go has unified entry and asyncEntry, so we could use sentinel.Entry(args) for both sync and async scenarios.
|
Nice work. Thanks for contributing! |
Describe what this PR does / why we need it
add dubbo-go adapter
Does this pull request fix one issue?
#55
Describe how you did it
Describe how to verify it
Special notes for reviews