Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix complie error: specified bound depends on the length of the source argument #312

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Conversation

drawing
Copy link
Contributor

@drawing drawing commented Jul 7, 2023

Fix compilation errors under gcc version 11.3.1 20221121 (Red Hat 11.3.1-4)

/tmp/build/xquic-1.5.2/src/tls/xqc_tls.c: In function 'xqc_tls_set_alpn':
/tmp/build/xquic-1.5.2/src/tls/xqc_tls.c:172:5: error: 'strncpy' specified bound depends on the length of the source argument [-Werror=stringop-truncation]
172 | strncpy(&p_alpn[1], alpn, protos_len);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/build/xquic-1.5.2/src/tls/xqc_tls.c:152:23: note: length computed here
152 | size_t alpn_len = strlen(alpn);
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors

@CLAassistant
Copy link

CLAassistant commented Jul 7, 2023

CLA assistant check
All committers have signed the CLA.

fix stringop-overflow complie error
@Kulsk Kulsk self-requested a review July 11, 2023 09:23
@Kulsk
Copy link
Collaborator

Kulsk commented Jul 12, 2023

LGTM

@Kulsk Kulsk merged commit aea7ffb into alibaba:main Jul 12, 2023
@Kulsk Kulsk linked an issue Jul 12, 2023 that may be closed by this pull request
cherylsy added a commit that referenced this pull request Oct 20, 2023
* [+] QUIC datagram (RFC9221), sending datagrams and bytestreams on http3 connections (non-standard extensions), and bugfix (#307)

*[!] fix vulnerabilities on parsing STREAM and CRYPTO frame;

* [+] update contributor

* [!] fix test case errors on ubuntu latest

* [+] Export SSL handler of HTTP/3 connection for ssl_protocol, ssl_cipher, etc. (#310)

* [+] Export SSL handler of HTTP/3 connection for ssl_protocol, ssl_cipher, etc.

* [!] fix format of function return

* [+] support standard stateless reset (#313)

* [+] update multipath to draft-04; (#317)

* [+] support pmtu;

* fix complie error: specified bound depends on the length of the source argument (#312)

* fix complie error: specified bound depends on the length of the source argument

* fix stringop-overflow complie error

* fix stringop-overflow complie error

* Doc/rfc9114 (#223)

* Update draft-ietf-quic-http-34-zh.md

* Update draft-ietf-quic-http-34-zh.md

* Update draft-ietf-quic-http-34-zh.md

* Create rfc9114-http3-zh.md

* [=] add usage specifications for test_client and test_server (#318)

* [+] support multipath interop (#320)

* [+] add no_crypto and serrial options for mpquic interop (#321)

* Update doc (and comment) multipath-[01|02] => 04 (#326)

* demo: fix typo (xuqic -> xquic) (#328)

* [+] add .gitignore (#329)

* fix: use off_t instead of int for filesize (#332)

* [!] fix http3 deadloop and segmentation fault, fix stream compose error (#338)


* [+]Enable multipath-05 etc. (#340)

* [=] fix README-zh-CN doc link (#341)

* [!] fix interop testcase: antiamplication, multiplexing, zerortt, recovery, keyupdate

* [~]Fix error during rebase

* [+]Add new testcase in run endpoint

---------

Co-authored-by: Wu Zhao <zhaowu.zw@alibaba-inc.com>
Co-authored-by: lianglli <liangli.liliang@alibaba-inc.com>
Co-authored-by: Bobo <cppbreak@qq.com>
Co-authored-by: robinhzp <9974622@qq.com>
Co-authored-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Co-authored-by: Yanmei Liu <miaoji.lym@alibaba-inc.com>
Co-authored-by: Marcel <marcel.kempf@tum.de>
Co-authored-by: RuiqiZhou <dangdang.zrq@alibaba-inc.com>
cherylsy added a commit to cherylsy/xquic that referenced this pull request Nov 7, 2023
…aba#347)

* [+] QUIC datagram (RFC9221), sending datagrams and bytestreams on http3 connections (non-standard extensions), and bugfix (alibaba#307)

*[!] fix vulnerabilities on parsing STREAM and CRYPTO frame;

* [+] update contributor

* [!] fix test case errors on ubuntu latest

* [+] Export SSL handler of HTTP/3 connection for ssl_protocol, ssl_cipher, etc. (alibaba#310)

* [+] Export SSL handler of HTTP/3 connection for ssl_protocol, ssl_cipher, etc.

* [!] fix format of function return

* [+] support standard stateless reset (alibaba#313)

* [+] update multipath to draft-04; (alibaba#317)

* [+] support pmtu;

* fix complie error: specified bound depends on the length of the source argument (alibaba#312)

* fix complie error: specified bound depends on the length of the source argument

* fix stringop-overflow complie error

* fix stringop-overflow complie error

* Doc/rfc9114 (alibaba#223)

* Update draft-ietf-quic-http-34-zh.md

* Update draft-ietf-quic-http-34-zh.md

* Update draft-ietf-quic-http-34-zh.md

* Create rfc9114-http3-zh.md

* [=] add usage specifications for test_client and test_server (alibaba#318)

* [+] support multipath interop (alibaba#320)

* [+] add no_crypto and serrial options for mpquic interop (alibaba#321)

* Update doc (and comment) multipath-[01|02] => 04 (alibaba#326)

* demo: fix typo (xuqic -> xquic) (alibaba#328)

* [+] add .gitignore (alibaba#329)

* fix: use off_t instead of int for filesize (alibaba#332)

* [!] fix http3 deadloop and segmentation fault, fix stream compose error (alibaba#338)

* [+]Enable multipath-05 etc. (alibaba#340)

* [=] fix README-zh-CN doc link (alibaba#341)

* [!] fix interop testcase: antiamplication, multiplexing, zerortt, recovery, keyupdate

* [~]Fix error during rebase

* [+]Add new testcase in run endpoint

---------

Co-authored-by: Wu Zhao <zhaowu.zw@alibaba-inc.com>
Co-authored-by: lianglli <liangli.liliang@alibaba-inc.com>
Co-authored-by: Bobo <cppbreak@qq.com>
Co-authored-by: robinhzp <9974622@qq.com>
Co-authored-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Co-authored-by: Yanmei Liu <miaoji.lym@alibaba-inc.com>
Co-authored-by: Marcel <marcel.kempf@tum.de>
Co-authored-by: RuiqiZhou <dangdang.zrq@alibaba-inc.com>
yangfurong pushed a commit that referenced this pull request Nov 8, 2023
* [!] fix interop testcase: antiamplication, multiplexing, zerortt, recovery, keyupdate

* [+] Add new case test & Merge master change into interop branch (#347)

* [+] QUIC datagram (RFC9221), sending datagrams and bytestreams on http3 connections (non-standard extensions), and bugfix (#307)

*[!] fix vulnerabilities on parsing STREAM and CRYPTO frame;

* [+] update contributor

* [!] fix test case errors on ubuntu latest

* [+] Export SSL handler of HTTP/3 connection for ssl_protocol, ssl_cipher, etc. (#310)

* [+] Export SSL handler of HTTP/3 connection for ssl_protocol, ssl_cipher, etc.

* [!] fix format of function return

* [+] support standard stateless reset (#313)

* [+] update multipath to draft-04; (#317)

* [+] support pmtu;

* fix complie error: specified bound depends on the length of the source argument (#312)

* fix complie error: specified bound depends on the length of the source argument

* fix stringop-overflow complie error

* fix stringop-overflow complie error

* Doc/rfc9114 (#223)

* Update draft-ietf-quic-http-34-zh.md

* Update draft-ietf-quic-http-34-zh.md

* Update draft-ietf-quic-http-34-zh.md

* Create rfc9114-http3-zh.md

* [=] add usage specifications for test_client and test_server (#318)

* [+] support multipath interop (#320)

* [+] add no_crypto and serrial options for mpquic interop (#321)

* Update doc (and comment) multipath-[01|02] => 04 (#326)

* demo: fix typo (xuqic -> xquic) (#328)

* [+] add .gitignore (#329)

* fix: use off_t instead of int for filesize (#332)

* [!] fix http3 deadloop and segmentation fault, fix stream compose error (#338)

* [+]Enable multipath-05 etc. (#340)

* [=] fix README-zh-CN doc link (#341)

* [!] fix interop testcase: antiamplication, multiplexing, zerortt, recovery, keyupdate

* [~]Fix error during rebase

* [+]Add new testcase in run endpoint

---------

Co-authored-by: Wu Zhao <zhaowu.zw@alibaba-inc.com>
Co-authored-by: lianglli <liangli.liliang@alibaba-inc.com>
Co-authored-by: Bobo <cppbreak@qq.com>
Co-authored-by: robinhzp <9974622@qq.com>
Co-authored-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Co-authored-by: Yanmei Liu <miaoji.lym@alibaba-inc.com>
Co-authored-by: Marcel <marcel.kempf@tum.de>
Co-authored-by: RuiqiZhou <dangdang.zrq@alibaba-inc.com>

* [~] Add mp option when running ./demo_server (#349)

* [~]enable gen new_conn_id (#352)

* [~]merge interop & Solve conflicts (#358)

[~] merge interop branch to main branch

* [+]Add interop mode signal & change param

* [~] Fix key update error & add interop mode in demo_client

* [~]add casetest being deleted accidentally

* [+] Add interop-mod param in run_endpoint.sh

* [~]fix rebase code

* [+]demo_server add interop param

* [~]add continue_send_reqs in hq_close_notify to fix multiplexing failed

---------

Co-authored-by: RuiqiZhou <dangdang.zrq@alibaba-inc.com>
Co-authored-by: Wu Zhao <zhaowu.zw@alibaba-inc.com>
Co-authored-by: lianglli <liangli.liliang@alibaba-inc.com>
Co-authored-by: Bobo <cppbreak@qq.com>
Co-authored-by: robinhzp <9974622@qq.com>
Co-authored-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Co-authored-by: Yanmei Liu <miaoji.lym@alibaba-inc.com>
Co-authored-by: Marcel <marcel.kempf@tum.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 编译错误,指定的界限取决于源参数的长度
3 participants