Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG. Env. Fix bug when setting step environment variables #55

Merged
merged 2 commits into from
Jan 12, 2022
Merged

BUG. Env. Fix bug when setting step environment variables #55

merged 2 commits into from
Jan 12, 2022

Conversation

franciscorode
Copy link
Contributor

@franciscorode franciscorode commented Jan 12, 2022 •
edited
Loading

I notice that envs defined in steps are not setting in some cases (see problem)

I tested it locally and seem is fullfill the second condition of below snippet when envs are present in a step

if step is None or not (hasattr(step, "envs") and not step.envs):
    return

@acostapazo acostapazo merged commit 0a2c8e5 into main Jan 12, 2022
@acostapazo acostapazo deleted the bugfix/set-step-envs branch January 12, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostapazo acostapazo acostapazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franciscorode @acostapazo