forked from whatwg/html
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use the Window's associated Document for allow-modals sandbox checks
This fixes whatwg#1206. As noted there, the previous indirections were wacky and unnecessary. Chrome and Firefox nightly implement a slightly different behavior, choosing the Window's browsing context's active Document, instead of the Window's associated Document. This can be different in edge cases as discussed in whatwg#1473 (comment). However, in Firefox they are not distinguishable, due to another security check that prevents these edge cases from being triggered. whatwg#1548 proposes to add a security check like Firefox's to the spec, which would obviate the difference in all cases. In the meantime, the choice of associated Document is more straightforward.
- Loading branch information
Showing
1 changed file
with
15 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters