-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory Usage #341
Memory Usage #341
Conversation
Hi, thanks for the PR and the kind words. I prefer to not have a dependency for something used this rare, but since the license is MIT we could add the file to the codebase (same as geohash and hyperloglog). Just that one file and the license+credits, I guess. |
After re-reading the doc and re-trying on my side on different types, indeed we need to do it across everything I took the suggestion of @alicebob to put the dependency in a folder and credit, I don't know for the polishing required
That would do, I guess I've changed the requirements a little bit since after re-reading the documentation this morning, it require to work on all types so I used the master map to switch on the types. I hope i didn't forgot something. The I've added two lines in the integration, i don't if it's what you wanted :P
|
Thanks for the fixes. It looks good, but I'll have a proper look soon. Can you squash it all so it's easier to merge? Thanks! |
notes based on master key After re-reading the doc and re-trying on my side on different types, indeed we need to do it across everything I took the suggestion of @alicebob to put the dependency in a folder and credit, I don't know for the polishing required Added small test
I think i need to sleep before doing other mistakes |
Merged, with some small fixes. I hope you got the credits for the commit. I'll make it a proper release in a few days. (The tests in |
It won't be 1:1 to Redis since it's adding overhead.
MEMORY USAGE foo
It's quite simple and using a dependency that got one file.
Story time: I was experimenting with
miniredis
+asynq
+rueidis
all on the same codebase just for fun, when i wanted to callGetTaskInfo
of asynq which lead me to this lua code that was throwing an error becauseminiredis
was missingMEMORY USAGE
. Usingminiredis
just like i would usesqlite
is just awesome.Please consider allowing sponsoring, I like to donate a bit for the code I use for my side projects :)
This PR will help
asynq
even though the maintainer doesn't even know about this case