Create VCPKG port

[fabiencastan]

Someone started a PR in this direction:
microsoft/vcpkg#8829

It would be good to finalize it, without hacking/patching the CMakeList.txt but doing the fixes needed directly in the repo.

[fabiencastan]

@ChaoJia @JackBoosY Would you be interested in helping us on that?

Currently the build of all the dependencies works fine on windows.
The build of the dependencies works almost fine on linux with the exception of alembic which is still a windows-only port file.

We also need to create the port files for https://github.com/alicevision/popsift, https://github.com/alicevision/CCTag and https://github.com/laurentkneip/opengv.

[fabiencastan]

PopSift PR: microsoft/vcpkg#10979

[fabiencastan]

Alembic PR: microsoft/vcpkg#10912

Regarding alembic there is a build error, due to -Werror in debug:
alembic/alembic#263
So there is a workaround in the vcpkg portfile.

[JackBoosY]

We very much look forward to you can propose more PRs to add more ports in vcpkg!

[fabiencastan]

CCTag PR: microsoft/vcpkg#16719

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[JackBoosY]

Will continue to add this to vcpkg.

[JackBoosY]

One question, I found the temporary code here:

AliceVision/src/CMakeLists.txt

Lines 301 to 308 in 6348b0f

	if(WIN32)
	# Disable BOOST autolink
	add_definitions(-DBOOST_ALL_NO_LIB)
	#To be removed later, a bug to make things work with current vcpkg
	#https://github.com/microsoft/vcpkg/issues/22495
	add_definitions(-DBOOST_USE_WINAPI_VERSION=BOOST_WINAPI_VERSION_WIN7)
	endif()

Why disable dynamic boost here?

I disabled the code block and built successfully.

[JackBoosY]

Another question:
We have cmake option ALICEVISION_USE_MESHSDFILTER here:

AliceVision/src/CMakeLists.txt

Line 77 in 6348b0f

option(ALICEVISION_USE_MESHSDFILTER "Use MeshSDFilter library (enable MeshDenoising and MeshDecimate)" ON)

However, the configure system checks whether meshsdfilter folder is exists:

AliceVision/src/CMakeLists.txt

Lines 181 to 185 in 6348b0f

	if(NOT EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/dependencies/MeshSDFilter/external)
	message(FATAL_ERROR
	"\n submodule(s) are missing, please update your repository:\n"
	" > git submodule update -i\n")
	endif()

I think the code block should requires ALICEVISION_USE_MESHSDFILTER is ON.

[simogasp]

I think the code block should requires ALICEVISION_USE_MESHSDFILTER is ON.

Yes, you are right, that piece of code should be surrounded by an IF (ALICEVISION_USE_MESHSDFILTER)

[JackBoosY]

@simogasp Can you explain why the first question happens?

[simogasp]

@simogasp Can you explain why the first question happens?

Sorry, I have no idea, does disabling auto-linking via BOOST_ALL_NO_LIB mean that dynamic linking is also disabled?

[JackBoosY]

Can anyone review my PR microsoft/vcpkg#38034?

[JackBoosY]

Ping for response.