-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[alembic] linux fixes #10912
[alembic] linux fixes #10912
Conversation
15593b8
to
6c6ea9b
Compare
Thanks for your PR! Can you please correct the Version field in the CONTROL file? You can get more information from maintainer-guide.md. |
I'm not sure if I should update the version number, as it doesn't change anything on windows. And on linux it has never been possible to build before, so there is no need for invalidation either. |
You need update the version in CONTROL. |
Ok, updated. |
Could you please remove |
Changed. I was not aware of this mechanism. |
Thanks for the PR @fabiencastan! Could you please revert the line ending change from LF to CRLF in |
e6e429f
to
a06519f
Compare
Hi @ras0219-msft, |
LGTM! Thanks @fabiencastan |
Describe the pull request
Fix the portfile to avoid windows-specific commands.
Fix a linux build error due to
-Werror
in the library in debug mode. The build issue has been also reported to the main repository alembic/alembic#263.The alembic port file was valid only for windows. This PR adds the support for linux.
Tested on windows-10 and ubuntu-18.04.
Yes