[depthMap] Code simplification #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SgmParams for SemiGlobalMatchingRc Parameters - Add RefineParams for RefineRc Parameters - Move sgmRcTc into SemiGlobalMatchingRc - Move refineRcTc into RefineRc
RcTc::smoothDepthMap and RcTc::filterDepthMap are unused and need methods that have already been removed
SemiGlobalMatchingParams ::getDepthSimMapFromBestIdVal is unused
IdDepthMap files are no longer generated
Propagate volDim (instead of volDimX, volDimY, volDimZ) and SgmParams
Reduce function call stack
And remove useless filename functions
…imMap And fix constness/typo
And fix constness/typo
And fix constness/typo
…apsGaussianKernelVoting
nDepthsToRefine was previously set to 15 for refineRcTcDepthMap, but always override and replaced by 31.
gregoire-dl
force-pushed
the
dev/depthMapSimplification
branch
from
939fad4 to
af3e09f
Compare
fabiencastan
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplification of the
depthMapmodule codeFeatures list
SgmParamsfor all Semi-Global Matching step parametersRefineParamsfor all Refine step parameters