Add NLMeans denoiser in ImageProcessing #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanstella
force-pushed
the
DenoiseNLMeansOpenCV
branch
from
3f71a07 to
2d538d9
Compare
p12tic
previously approved these changes
Oct 3, 2022
p12tic
reviewed
Oct 3, 2022
cbentejac
force-pushed
the
DenoiseNLMeansOpenCV
branch
from
2d538d9 to
c5ad707
Compare
add associated parameters
OpenCV's core/core.hpp and photo/cuda.hpp are not needed to use the implementation of fast non-local means denoising.
This commit corrects a few typos in the comments dedicated to the NL Means and it updates the default value of the "filterStrengthColor" parameter to 10.f (instead of 5.f), as recommended by OpenCV's documentation.
This commit moves the implementation of cvMatBGRToImageRGBA into a dedicated template function (cvMatBGRToImageRGBAImpl). The documentation for both methods is added and updated where needed.
This commit harmonizes the descriptions of existing and unmodified functions, and corrects an error with the Doxygen tags.
fcastan
force-pushed
the
DenoiseNLMeansOpenCV
branch
from
68365fe to
7e029a7
Compare
fabiencastan
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new denoising method (Non-Local Means from OpenCV) in the ImageProcessing node.
NL Means support in Meshroom is added in alicevision/Meshroom#1719.
Implementation remarks