[bugfix] fix getColmapCompatibleViews #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using find with two different vectors!
simogasp
force-pushed
the
dev/colmap_exporter
branch
from
53913ed to
90e05dd
Compare
fabiencastan
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the code of
compatibleIntrinsics(), in order to check if an element belongs to the vector,find()was used and compared to the.end()of a different vector. (self-facepalm).This made the unit test fail (only) on windows. Why that was not failing on Linux, it's a big mystery.
Incidentally it fixes the name of the unit test for middlebury, which was missing the proper module prefix